New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure image measurement functions #210

Merged
merged 5 commits into from Oct 23, 2014

Conversation

Projects
None yet
2 participants
@adonath
Member

adonath commented Oct 17, 2014

This PR includes a restructuring of the image measure functions, a new measure_curve_of_growth function and tests for all measurement functions. All functions were change to use an ImageHDU and world coordinates.

@adonath

This comment has been minimized.

Show comment
Hide comment
@adonath

adonath Oct 20, 2014

Member

@cdeil The fail of the docs build doesn't seem to be related to this PR.

Member

adonath commented Oct 20, 2014

@cdeil The fail of the docs build doesn't seem to be related to this PR.

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Oct 23, 2014

Member

The failure was unrelated and fixed in cdeil@7834d95 ... now travis-ci passes for this PR ... merging now.

All of this is or should really be in photutils ... but as a temp solution it's OK to just put what we need in gammapy.

Member

cdeil commented Oct 23, 2014

The failure was unrelated and fixed in cdeil@7834d95 ... now travis-ci passes for this PR ... merging now.

All of this is or should really be in photutils ... but as a temp solution it's OK to just put what we need in gammapy.

cdeil added a commit that referenced this pull request Oct 23, 2014

@cdeil cdeil merged commit ce2d901 into gammapy:master Oct 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Oct 23, 2014

Member

Thanks!

Member

cdeil commented Oct 23, 2014

Thanks!

@cdeil cdeil changed the title from Restructured image measurement functions to Restructure image measurement functions Apr 8, 2015

@cdeil cdeil added the feature label Apr 8, 2015

@cdeil cdeil added this to the 0.2 milestone Apr 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment