Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure image measurement functions #210

Merged
merged 5 commits into from Oct 23, 2014

Conversation

@adonath
Copy link
Member

@adonath adonath commented Oct 17, 2014

This PR includes a restructuring of the image measure functions, a new measure_curve_of_growth function and tests for all measurement functions. All functions were change to use an ImageHDU and world coordinates.

@adonath adonath force-pushed the restructure_containment_measure branch from e7798d3 to a1035b0 Oct 17, 2014
@adonath
Copy link
Member Author

@adonath adonath commented Oct 20, 2014

@cdeil The fail of the docs build doesn't seem to be related to this PR.

Loading

@adonath adonath force-pushed the restructure_containment_measure branch from a1035b0 to f310784 Oct 22, 2014
@cdeil
Copy link
Member

@cdeil cdeil commented Oct 23, 2014

The failure was unrelated and fixed in cdeil@7834d95 ... now travis-ci passes for this PR ... merging now.

All of this is or should really be in photutils ... but as a temp solution it's OK to just put what we need in gammapy.

Loading

cdeil pushed a commit that referenced this issue Oct 23, 2014
Restructured image measurement functions
@cdeil cdeil merged commit ce2d901 into gammapy:master Oct 23, 2014
1 check passed
Loading
@cdeil
Copy link
Member

@cdeil cdeil commented Oct 23, 2014

Thanks!

Loading

@cdeil cdeil changed the title Restructured image measurement functions Restructure image measurement functions Apr 8, 2015
@cdeil cdeil added the feature label Apr 8, 2015
@cdeil cdeil added this to the 0.2 milestone Apr 8, 2015
@adonath adonath deleted the restructure_containment_measure branch Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants