Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MapAxis.edges and MapAxis.center attributes to quantities #2132

Merged
merged 4 commits into from May 7, 2019

Conversation

@AtreyeeS
Copy link
Member

@AtreyeeS AtreyeeS commented May 7, 2019

This PR makes MapAxis as a quantity.

@adonath adonath self-assigned this May 7, 2019
@adonath adonath added this to To do in gammapy.maps via automation May 7, 2019
@adonath adonath added this to the 0.12 milestone May 7, 2019
@adonath adonath self-requested a review May 7, 2019
@adonath
Copy link
Member

@adonath adonath commented May 7, 2019

Thanks a lot @AtreyeeS! I've made one follow-up commit including a bit of clean-up (7c86be5). Otherwise looks good to me!

@adonath adonath merged commit b791c06 into gammapy:master May 7, 2019
7 of 9 checks passed
gammapy.maps automation moved this from To do to Done May 7, 2019
Copy link
Member

@adonath adonath left a comment

I have no further comments.

@adonath adonath changed the title Make MapAxis.edges and MapAxis.center as a quantity Make MapAxis.edges and MapAxis.center return quantity May 27, 2019
@adonath adonath changed the title Make MapAxis.edges and MapAxis.center return quantity Change MapAxis.edges and MapAxis.center attributes to quantities May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
gammapy.maps
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants