Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MapAxis.edges and MapAxis.center attributes to quantities #2132

Merged
merged 4 commits into from May 7, 2019

Conversation

2 participants
@AtreyeeS
Copy link
Member

commented May 7, 2019

This PR makes MapAxis as a quantity.

@adonath adonath self-assigned this May 7, 2019

@adonath adonath added this to To do in Map analysis via automation May 7, 2019

@adonath adonath added this to the 0.12 milestone May 7, 2019

@adonath adonath self-requested a review May 7, 2019

@adonath

This comment has been minimized.

Copy link
Member

commented May 7, 2019

Thanks a lot @AtreyeeS! I've made one follow-up commit including a bit of clean-up (7c86be5). Otherwise looks good to me!

@adonath adonath merged commit b791c06 into gammapy:master May 7, 2019

7 of 9 checks passed

Scrutinizer Running
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
gammapy.gammapy Build #20190507.9 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python35) Test Python35 succeeded
Details
gammapy.gammapy (Test Windows35) Test Windows35 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details

Map analysis automation moved this from To do to Done May 7, 2019

@adonath
Copy link
Member

left a comment

I have no further comments.

@adonath adonath changed the title Make MapAxis.edges and MapAxis.center as a quantity Make MapAxis.edges and MapAxis.center return quantity May 27, 2019

@adonath adonath changed the title Make MapAxis.edges and MapAxis.center return quantity Change MapAxis.edges and MapAxis.center attributes to quantities May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.