Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up spectral tutorials #2140

Merged
merged 3 commits into from May 20, 2019

Conversation

2 participants
@AtreyeeS
Copy link
Member

commented May 15, 2019

This PR cleans up spectral tutorials as outlined in #2137.

@adonath adonath self-assigned this May 15, 2019

@adonath adonath added the cleanup label May 15, 2019

@adonath adonath added this to To Do in Documentation via automation May 15, 2019

@adonath adonath added this to the 0.12 milestone May 15, 2019

@adonath adonath self-requested a review May 17, 2019

@adonath
Copy link
Member

left a comment

Thanks @AtreyeeS! Before we can merge you have to adapt the gammapy/tutorials/notebooks.yaml file and delete the entries for the notebooks you removed from there. Please also check whether you have to adapt gammapy/docs/tutorials.rst.

Otherwise I don't have any comments...

AtreyeeS added some commits May 18, 2019

@adonath adonath merged commit e33fd5e into gammapy:master May 20, 2019

4 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
gammapy.gammapy Build #20190518.2 had test failures
Details
gammapy.gammapy (Test Python35) Test Python35 failed
Details
gammapy.gammapy (Test Windows35) Test Windows35 failed
Details
gammapy.gammapy (Test Windows37) Test Windows37 failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details

Documentation automation moved this from To Do to Done May 20, 2019

@adonath

This comment has been minimized.

Copy link
Member

commented May 20, 2019

Thanks @AtreyeeS, the CI fails were unrelated...

@adonath adonath changed the title Cleanup of spectral tutorials Clean up spectral tutorials May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.