Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SkyDisk and SkyEllipse edge parameter #2141

Merged
merged 3 commits into from May 16, 2019

Conversation

Projects
1 participant
@adonath
Copy link
Member

commented May 15, 2019

This PR implements an edge parameter for the SkyDisk and SkyEllipse model. This additional parameter is introduced to resolve #2109.

@adonath adonath self-assigned this May 15, 2019

@adonath adonath added the feature label May 15, 2019

@adonath adonath added this to In progress in Modeling via automation May 15, 2019

@adonath adonath added this to the 0.12 milestone May 15, 2019

@adonath adonath merged commit 96fb1f5 into gammapy:master May 16, 2019

7 of 9 checks passed

gammapy.gammapy Build #20190515.10 was canceled
Details
gammapy.gammapy (DevDocs)
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 3 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python35) Test Python35 succeeded
Details
gammapy.gammapy (Test Windows35) Test Windows35 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details

Modeling automation moved this from In progress to Done May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.