Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement oversampling option for background model evaluation #2142

Merged
merged 2 commits into from May 16, 2019

Conversation

Projects
None yet
1 participant
@adonath
Copy link
Member

commented May 16, 2019

This PR implements an oversampling option for the background model evaluation in the MapMaker class. The default behaviour remains unchanged, but users have now the option to choose the oversampling factor for the energy integration of the background model, if they want to.

This PR supersedes: #2083 by @lmohrmann.

@adonath adonath self-assigned this May 16, 2019

@adonath adonath added the feature label May 16, 2019

@adonath adonath added this to the 0.12 milestone May 16, 2019

@adonath adonath requested a review from lmohrmann May 16, 2019

@adonath adonath force-pushed the adonath:bkg_oversampling branch from dd9e6a0 to efecb04 May 16, 2019

@adonath adonath merged commit fafa76d into gammapy:master May 16, 2019

4 of 9 checks passed

gammapy.gammapy Build #20190516.4 had test failures
Details
gammapy.gammapy (Test Python35) Test Python35 failed
Details
gammapy.gammapy (Test Windows35) Test Windows35 failed
Details
gammapy.gammapy (Test Windows37) Test Windows37 failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details

@adonath adonath changed the title Implement oversampling option for background model evaluation. Implement oversampling option for background model evaluation May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.