Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SpectrumDataset.counts_on attribute to SpectrumDataset.counts #2157



2 participants
Copy link

commented May 23, 2019

This PR modifies the name of the counts_on attribute to counts.
This ensures naming consistency with other datasets, e.g. MapDataset and should allow a more uniform treatment in other parts of the code (e.g. in utils/fitting).

@registerrier registerrier self-assigned this May 23, 2019

@registerrier registerrier added this to To do in Spectrum analysis (1D) via automation May 23, 2019

@registerrier registerrier added this to the 0.12 milestone May 23, 2019

@registerrier registerrier requested a review from adonath May 23, 2019

Copy link

left a comment

Thanks @registerrier! I have no comments, I'll wait for Travis to pass and the merge.

@adonath adonath merged commit d08ed28 into gammapy:master May 23, 2019

7 of 9 checks passed

gammapy.gammapy Build #20190523.6 had test failures
gammapy.gammapy (Test Windows37) Test Windows37 failed
Codacy/PR Quality Review Up to standards. A positive pull request.
Scrutinizer Analysis: No new issues – Tests: passed
continuous-integration/travis-ci/pr The Travis CI build passed
gammapy.gammapy (DevDocs) DevDocs succeeded
gammapy.gammapy (Lint) Lint succeeded
gammapy.gammapy (Test Python35) Test Python35 succeeded
gammapy.gammapy (Test Windows35) Test Windows35 succeeded

Spectrum analysis (1D) automation moved this from To do to Done May 23, 2019

@adonath adonath changed the title Change counts_on to counts attribute in SpectrumDatasetOnOff Rename SpectrumDataset.counts_on attribute to SpectrumDataset.counts May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.