Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove PHACountsSpectrumList class #2166
The PR removes
Note that the export to Type II files was assuming identical
For reference: this was added in #783
IMO it would be nice to have a way to write and read a list of spectrum extractions to a single FITS file. This could create 1000 HDUs and be 100 MB - that's fine, its still nice to have have a single-file solution. But also making ZIP files for a serialisation to a folder is a single-file solution.
Overall I think removing this is good, and then to only add back stuff with tests (in this case this functionality was untested) and if there's a clear need (which might or might not be there for this OGIP II format, once we have added nice support for OGIP I format).