Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Poisson chi2 approximations #2171

Merged
merged 1 commit into from May 27, 2019

Conversation

Projects
None yet
3 participants
@cdeil
Copy link
Member

commented May 27, 2019

This PR removes a few functions in gammapy.stats that are chi2 approximations of Poisson data.

I think I added those years ago following http://cxc.harvard.edu/sherpa/statistics/

But I don't think we or users ever used them, and using those stats is pretty dubious. They are completely untested. I'd prefer to remove, as opposed to improve (i.e. add tests and docs).

@adonath @registerrier - Thoughts?

@cdeil cdeil added the cleanup label May 27, 2019

@cdeil cdeil added this to the 0.12 milestone May 27, 2019

@cdeil cdeil requested review from adonath and registerrier May 27, 2019

@cdeil cdeil self-assigned this May 27, 2019

@registerrier

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

Hi @cdeil , while they are not used for now those statistics might be of use if we are to support simultaneous fitting with X-ray data.

Since those are untested I guess it might better to remove, yet this functionality should be in at some point.

@adonath
Copy link
Member

left a comment

I agree we should remove it for now.

@cdeil

This comment has been minimized.

Copy link
Member Author

commented May 27, 2019

@registerrier - My concern is to create a clean, well-tested Gammapy v1.0 in the little time we have left and to focus coding / testing / docs effort on that part. I do expect that a lot of functionality will be added in the coming years, such as e.g. this rarely used functionality.

@cdeil cdeil merged commit 9ea90e8 into gammapy:master May 27, 2019

8 of 9 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
gammapy.gammapy Build #20190527.21 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python35) Test Python35 succeeded
Details
gammapy.gammapy (Test Windows35) Test Windows35 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.