Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up gammapy.utils.random #2204

Merged
merged 5 commits into from Jun 6, 2019
Merged

Conversation

@fabiopintore
Copy link
Contributor

@fabiopintore fabiopintore commented Jun 4, 2019

This PR introduce a renaming of the gammapy.utils.distributions' into gammapy.utils.random'. The content of the current `gammapy.utils.random' is moved in the new folder.

Then the currently unused GeneralRandomArray class is removed from gammapy.utils.random' and substituted by the new InverseCDFSampler class (inverse_cdf.py'). Some tests for this latter class are added.

@cdeil cdeil changed the title Random cleanup Clean-up in gammapy.utils.random Jun 4, 2019
@cdeil cdeil added the cleanup label Jun 4, 2019
@cdeil cdeil added this to the 0.13 milestone Jun 4, 2019
@adonath adonath force-pushed the random_cleanup branch from 86c6b8b to c76a800 Jun 6, 2019
adonath
adonath approved these changes Jun 6, 2019
Copy link
Member

@adonath adonath left a comment

Thanks @fabiopintore! This is ready to merge now...

@adonath adonath merged commit b3b40ce into gammapy:master Jun 6, 2019
9 checks passed
@cdeil cdeil mentioned this pull request Jun 7, 2019
@adonath adonath changed the title Clean-up in gammapy.utils.random Clean up gammapy.utils.random Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants