Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gammapy download #2217

Merged
merged 11 commits into from Jun 6, 2019
Merged

Refactor gammapy download #2217

merged 11 commits into from Jun 6, 2019

Conversation

@Bultako
Copy link
Member

@Bultako Bultako commented Jun 6, 2019

This PR is a clean-up and refactoring of the code for gammapy download, as suggested in #2178 (comment)

We can finish polishing and discuss it in face-to-face coding session in Erlangen coding-sprint.

@Bultako Bultako self-assigned this Jun 6, 2019
@Bultako Bultako added the cleanup label Jun 6, 2019
Copy link
Member

@cdeil cdeil left a comment

@Bultako - Thanks!

Please merge if CI passes.

@cdeil cdeil added this to the 0.13 milestone Jun 6, 2019
Copy link
Member

@cdeil cdeil left a comment

I haven't used it much yet, but in this case you could consider using the "squash and merge" feature of Github and give a clear message, given that the individual commits and messages aren't very useful. As you like.

cdeil
cdeil approved these changes Jun 6, 2019
@Bultako Bultako merged commit 2b94177 into gammapy:master Jun 6, 2019
9 checks passed
@Bultako Bultako deleted the refactor branch Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants