Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spectrum/models.py coverage #2230

Merged
merged 5 commits into from Jun 13, 2019

Conversation

@registerrier
Copy link
Contributor

@registerrier registerrier commented Jun 12, 2019

This PR adds a few tests to improve the coverage of spectrum/models.py.

@registerrier registerrier added this to the 0.13 milestone Jun 12, 2019
@registerrier registerrier requested a review from adonath Jun 12, 2019
Copy link
Member

@adonath adonath left a comment

Thanks @registerrier! This looks good to me, I just have one minor comment...

@@ -214,7 +252,7 @@ def test_models(spectrum):
assert_quantity_allclose(model.e_peak, spectrum["e_peak"], rtol=1e-2)

# inverse for TableModel is not implemented
Copy link
Member

@adonath adonath Jun 13, 2019

Copy link
Contributor Author

@registerrier registerrier Jun 13, 2019

OK. Done, it works.

Copy link
Member

@adonath adonath left a comment

Looks good to me now. I have no further comments...

@adonath adonath merged commit 7060491 into gammapy:master Jun 13, 2019
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants