Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pulsar spin-down model bug #2294

Merged
merged 2 commits into from Jul 25, 2019
Merged

Fix pulsar spin-down model bug #2294

merged 2 commits into from Jul 25, 2019

Conversation

@manconi
Copy link

@manconi manconi commented Jul 17, 2019

This PR is opened in order to fix the bug in the class Pulsar:
#2249

The update in the reference values in the tests (https://github.com/gammapy/gammapy/blob/master/gammapy/astro/population/tests/test_simulate.py#L108) is not included.

@cdeil cdeil added the bug label Jul 17, 2019
@cdeil cdeil added this to the 0.13 milestone Jul 17, 2019
@cdeil cdeil changed the title fix-psr-bug Fix Pulsar bug Jul 19, 2019
@adonath
Copy link
Member

@adonath adonath commented Jul 24, 2019

Thanks a lot @manconi and sorry for the delay on this! I just pushed a commit to update the test values. Once the CI build passed I will merge the PR. So it will available in Gammapy v0.13, which will be released by the end of this week.

I didn't have time to check this change in depth, but at least the formula agree with the references now. I guess in general it could be nice to add section with a few figures to https://docs.gammapy.org/0.12/notebooks/source_population_model.html, which compare the simulated pulsar population with the one from ATNF. This would be very illustrative and helpful for many users. Please let me know, if you are interested to work on this (I guess you have some code for this anyway...).

@adonath adonath merged commit 54fdee9 into gammapy:master Jul 25, 2019
9 checks passed
@adonath adonath changed the title Fix Pulsar bug Fix pulsar spin-down model bug Jul 25, 2019
@manconi
Copy link
Author

@manconi manconi commented Jul 25, 2019

Thanks @adonath for adding this PR.
Yes, I could isolate from my codes some basic script to compare the properties of simulated pulsar with the one of the ATNF. Since the ATNF is continously updated, It would be also nice to have some direct interface with the ATNF list. I will think a little bit about the best way of doing it in the next days, and I will be back to you with some proposal.

@adonath
Copy link
Member

@adonath adonath commented Jul 25, 2019

Thanks @manconi, I'll be on holiday (and other Gammapy developers as well) until mid-august. But we should definitely come back to this, once I'm back...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants