Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SpectrumSimulation class #2305

Merged
merged 6 commits into from Jul 22, 2019

Conversation

@adonath
Copy link
Member

@adonath adonath commented Jul 22, 2019

This PR includes the following changes:

  • Remove the SpectrumSimulation class and replace all it's uses with .fake()
  • Adapt all tests
  • Adapt spectrum_simulation.ipynb tutorial
@adonath adonath self-assigned this Jul 22, 2019
@adonath adonath added this to the 0.13 milestone Jul 22, 2019
@adonath adonath force-pushed the clean_up_datasets_fake_methods branch from dbb4f1c to abeb128 Jul 22, 2019
@adonath adonath merged commit 2dbd510 into gammapy:master Jul 22, 2019
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant