Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dissolve gammapy.background #2320

Merged
merged 10 commits into from Aug 30, 2019

Conversation

@cdeil
Copy link
Member

commented Aug 30, 2019

As agreed in #2274 we should dissolve gammapy.background, moving its code into gammapy.spectrum and gammapy.cube.

See detailed notes in the PIG: https://github.com/gammapy/gammapy/blob/master/docs/development/pigs/pig-016.rst#dissolve-gammapybackground

@cdeil cdeil added the cleanup label Aug 18, 2019
@cdeil cdeil added this to the 0.14 milestone Aug 18, 2019
@cdeil cdeil self-assigned this Aug 18, 2019
@cdeil cdeil requested a review from adonath Aug 30, 2019
@cdeil

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

I've dissolved gammapy.background as described in the PIG.
The diff is small and simple.
@adonath - Want to review?

@cdeil

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

Bye bye background

@cdeil cdeil merged commit 68930bc into gammapy:master Aug 30, 2019
9 checks passed
9 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 64 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20190830.25 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
@adonath

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.