Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dissolve gammapy.image #2321

Merged
merged 8 commits into from Sep 3, 2019

Conversation

@cdeil
Copy link
Member

commented Sep 3, 2019

As agreed in #2274 we should dissolve gammapy.image, moving the useful functionality to gammapy.maps and gammapy.cube.

See https://github.com/gammapy/gammapy/blob/master/docs/development/pigs/pig-016.rst#dissolve-gammapyimage

@cdeil cdeil added the cleanup label Aug 18, 2019
@cdeil cdeil added this to the 0.14 milestone Aug 18, 2019
@cdeil cdeil self-assigned this Aug 18, 2019
@cdeil

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

@adonath - Ready for final review.
(would prefer to to review & improvements of the code in future PRs, just do the move here)

@cdeil cdeil merged commit c9ed2c6 into gammapy:master Sep 3, 2019
9 checks passed
9 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 5 new issues, 72 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20190903.4 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.