Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in the spectral gaussian model evaluate method #2326

Merged
merged 2 commits into from Aug 27, 2019

Conversation

@JouvinLea
Copy link
Contributor

commented Aug 26, 2019

Fix the issue #2325

@JouvinLea JouvinLea requested a review from adonath Aug 26, 2019
Copy link
Member

left a comment

Thanks @JouvinLea! Can you please add a regression test or modify the existing test, so that it becomes sensitive to the changes introduced in this PR?

@adonath adonath self-assigned this Aug 26, 2019
@adonath adonath added this to the 0.14 milestone Aug 26, 2019
@adonath adonath added the bug label Aug 26, 2019
@JouvinLea

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

I added a test at 3 TeV for the Gaussian and LogGaussian Model that is different if we forget the - !!!

@adonath adonath merged commit 59f7c13 into gammapy:master Aug 27, 2019
9 checks passed
9 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 1 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20190827.1 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
@adonath

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

Thanks @JouvinLea!

@adonath adonath changed the title Fix bug in the Gaussian model evaluate method Fix bug in the spectral gaussian model evaluate method Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.