Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SpectrumAnalysisIACT class #2335

Merged
merged 4 commits into from Sep 3, 2019

Conversation

@Bultako
Copy link
Member

commented Sep 2, 2019

This PR removes SpectrumAnalysisIACT and adapts the HESS notebook to perform the spectrum 1D analysis that was made by SpectrumAnalysisIACT class, now with the high-level interface.

@cdeil cdeil self-assigned this Sep 2, 2019
@cdeil cdeil added the cleanup label Sep 2, 2019
@cdeil cdeil added this to the 0.14 milestone Sep 2, 2019
@cdeil
cdeil approved these changes Sep 2, 2019
Copy link
Member

left a comment

@Bultako - Thanks. This looks good.

For me locally tests and make docs-all pass.

On travis-ci all was read, from what I can see from data download fails.
I've re-started CI - will check back tomorrow morning and merge this in.

@cdeil

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

CI fails are unrelated, see #2332 (comment)

I'm merging this PR now. Should be OK, everything works for me locally, and if there's an issue we can fix it up later today in master.

@cdeil cdeil merged commit bddde6e into gammapy:master Sep 3, 2019
8 of 9 checks passed
8 of 9 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
gammapy.gammapy Build #20190902.12 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
@Bultako Bultako deleted the Bultako:HLI-replace branch Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.