Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `SpectrumDataset.create()` #2345

Merged

Conversation

@registerrier
Copy link
Contributor

commented Sep 6, 2019

This is a first PR to introduce creation of empty datasets for data reduction processing.

The counts and background are empty. the aeff is 0 but edisp is diagonal.
livetime is set to 0 as well.

@registerrier registerrier added the feature label Sep 6, 2019
@registerrier registerrier added this to the 0.14 milestone Sep 6, 2019
@registerrier registerrier requested a review from adonath Sep 6, 2019
@registerrier registerrier added this to To do in Spectrum analysis (1D) via automation Sep 6, 2019
Copy link
Member

left a comment

Thanks @registerrier! I've left one comment to maybe also add an empty GTI table to the dataset, otherwise it looks good to me!

gammapy/spectrum/dataset.py Show resolved Hide resolved
@adonath adonath changed the title Add spectrumdataset create Add `SpectrumDataset.create()` Sep 6, 2019
Copy link
Member

left a comment

Thanks a lot @registerrier! I've left two more minor inline comments. Once those are addressed I would suggest to merge...

gammapy/spectrum/dataset.py Show resolved Hide resolved
gammapy/spectrum/dataset.py Outdated Show resolved Hide resolved
@registerrier registerrier merged commit b70951e into gammapy:master Sep 6, 2019
7 of 9 checks passed
7 of 9 checks passed
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Scrutinizer Analysis: 4 updated code elements – Tests: passed
Details
gammapy.gammapy Build #20190906.6 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
Spectrum analysis (1D) automation moved this from To do to Done Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.