Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `SpectrumDatasetOnOff.create()` #2346

Merged

Conversation

@registerrier
Copy link
Contributor

commented Sep 6, 2019

This PR is a follow up of #2345 . It adds the create() to the SpectrumDatasetOnOff

  • The safe_mask is set to False everywhere (because stacking is a logical or for the mask
  • The acceptance and acceptance_off are set to one
@registerrier registerrier requested a review from adonath Sep 6, 2019
@registerrier registerrier added the feature label Sep 6, 2019
@registerrier registerrier added this to To do in Spectrum analysis (1D) via automation Sep 6, 2019
@registerrier registerrier added this to the 0.14 milestone Sep 6, 2019
@adonath

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Thanks @registerrier! There is a merge conflict, that has to be resolved, others looks good to me. I have no further comments...

@registerrier registerrier force-pushed the registerrier:add_spectrumdataset_create branch from 4d7f978 to 44b1cfe Sep 9, 2019
registerrier added 2 commits Sep 9, 2019
@registerrier registerrier merged commit af159de into gammapy:master Sep 9, 2019
9 checks passed
9 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 3 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20190909.14 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
Spectrum analysis (1D) automation moved this from To do to Done Sep 9, 2019
@registerrier

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

Tests have passed. Merging now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.