Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move gammapy.utils.fitting to gammapy.modeling #2354

Merged
merged 2 commits into from Sep 9, 2019

Conversation

@cdeil
Copy link
Member

commented Sep 9, 2019

This PR is another step for #2319. It moves gammapy.utils.fitting to gammapy.modeling.

In gammapy/modeling/__init__.py I've put this:

"""Models and fitting."""
from .datasets import *
from .fit import *
from .model import *
from .parameter import *
from .sampling import *

This exposes the main classes, but not the backend-specific functions in the API docs.
For sampling.py we don't have a good API yet (tracked in #2304), for now it's content exposed in the API docs.

@cdeil cdeil added the cleanup label Sep 9, 2019
@cdeil cdeil added this to the 0.14 milestone Sep 9, 2019
@cdeil cdeil requested a review from adonath Sep 9, 2019
@cdeil cdeil self-assigned this Sep 9, 2019
@cdeil cdeil added this to In progress in Modeling via automation Sep 9, 2019
@adonath
adonath approved these changes Sep 9, 2019
Copy link
Member

left a comment

Thanks a lot @cdeil! Looks good to me, I have no further comments...

@cdeil

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2019

make test and make docs-all is working locally. Merging this PR now.

This is what we currently have in the API docs:

Screenshot 2019-09-09 at 15 05 16

@cdeil cdeil merged commit b95cb88 into gammapy:master Sep 9, 2019
6 of 9 checks passed
6 of 9 checks passed
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
Scrutinizer Created
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
gammapy.gammapy Build #20190909.21 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
Modeling automation moved this from In progress to Done Sep 9, 2019
@cdeil cdeil referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Modeling
  
Done
2 participants
You can’t perform that action at this time.