Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `SpectrumDataset.stack()` #2356

Merged
merged 8 commits into from Sep 9, 2019

Conversation

@registerrier
Copy link
Contributor

commented Sep 9, 2019

This PR adds a stack() method to SpectrumDataset. The stacking is done in-place.

To properly deal with the safe_mask when it is not set, I have added a property to have it return a vector of True values.

@registerrier registerrier requested a review from adonath Sep 9, 2019
@registerrier registerrier added the feature label Sep 9, 2019
@registerrier registerrier added this to To do in Spectrum analysis (1D) via automation Sep 9, 2019
@registerrier registerrier added this to the 0.14 milestone Sep 9, 2019
Copy link
Member

left a comment

Thanks @registerrier, I've left a few minor comments regarding the handling of the None cases, otherwise it looks good to me...

gammapy/spectrum/dataset.py Outdated Show resolved Hide resolved
gammapy/spectrum/dataset.py Outdated Show resolved Hide resolved
gammapy/spectrum/dataset.py Show resolved Hide resolved
@registerrier registerrier merged commit fcb3884 into gammapy:master Sep 9, 2019
7 of 9 checks passed
7 of 9 checks passed
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Scrutinizer Analysis: 4 updated code elements – Tests: passed
Details
gammapy.gammapy Build #20190909.26 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
Spectrum analysis (1D) automation moved this from To do to Done Sep 9, 2019
@registerrier

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

Merging now.

adonath added a commit that referenced this pull request Sep 9, 2019
@adonath

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

Thanks @registerrier, I did a little bit of clean-up in 93b2478.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.