Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gammapy/maps/measure.py #2365

Merged
merged 1 commit into from Sep 16, 2019

Conversation

@cdeil
Copy link
Member

commented Sep 15, 2019

This PR removes gammapy/maps/measure.py, which used to be gammapy/image/measure.py

When dissolving gammapy.image in #2321, @adonath and I discussed whether it would be useful to keep, and (I think) concluded that for these four helper functions it's better to remove them.

The idea is to add examples how to do region-based measurements in the Gammapy docs in the future, using gammapy.maps API or possibly https://photutils.readthedocs.io . We could also add back functionality in Gammapy, but then we'd probably want better implementations, that e.g. allow also extra axes such as an energy axis. At this point, it's not sure if this functionality is really needed, so IMO it's better to remove it, and as needed, add back high-quality implementations with docs later.

@cdeil cdeil added the cleanup label Sep 15, 2019
@cdeil cdeil added this to the 0.14 milestone Sep 15, 2019
@cdeil cdeil added this to To do in Map analysis via automation Sep 15, 2019
Copy link
Member

left a comment

Thanks @cdeil! No further comments from my side...

@cdeil cdeil merged commit 7512948 into gammapy:master Sep 16, 2019
9 checks passed
9 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20190915.1 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
Map analysis automation moved this from To do to Done Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Map analysis
  
Done
2 participants
You can’t perform that action at this time.