Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup `WcsNDMap` FITS convention handling #2379

Merged
merged 3 commits into from Sep 19, 2019

Conversation

@adonath
Copy link
Member

commented Sep 19, 2019

This PR cleans-up and simplifies the fits convention handling for maps. It includes the following changes:

  • Remove the Map.conv attribute
  • Move the handling of conv completely to I/O methods
  • Simplify find_and_read_bands method
@adonath adonath self-assigned this Sep 19, 2019
@adonath adonath added the cleanup label Sep 19, 2019
@adonath adonath added this to the 0.14 milestone Sep 19, 2019
@adonath adonath merged commit b9f81e2 into gammapy:master Sep 19, 2019
9 checks passed
9 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 6 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20190919.16 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.