Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change spatial model default frame to icrs #2385

Merged
merged 3 commits into from Sep 23, 2019

Conversation

@cdeil
Copy link
Member

commented Sep 22, 2019

This PR changes the spatial model default frame from "galactic" to "icrs".

Using ICRS is much more common in astronomy, Galactic frame is more exotic, that was introduced just because the Gammapy devs do Galactic science.

Putting "icrs" gives consistency with SkyCoord and Map.

@adonath - Could you please fix this reference file?
https://gist.github.com/cdeil/53057a588522e1fe8ec521214d67606f
It's pretty annoying to have this non-stable reference data file while we iterate on models. E.g. it will need another update once we change any parameter or model name. I guess it's hard to avoid that reference file.

@cdeil cdeil added the cleanup label Sep 22, 2019
@cdeil cdeil added this to the 0.14 milestone Sep 22, 2019
@cdeil cdeil added this to In progress in Modeling via automation Sep 22, 2019
@adonath

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

I appended one commit adding the frame attribute to the model serialisation and updated the test files in gammapy/gammapy-extra@417b97c. Travis should go green now...

@adonath adonath merged commit 3e6a033 into gammapy:master Sep 23, 2019
8 of 9 checks passed
8 of 9 checks passed
Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20190923.1 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
Modeling automation moved this from In progress to Done Sep 23, 2019
@adonath

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

Thanks @cdeil! Please go ahead with you cleanup of the spatial models...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Modeling
  
Done
2 participants
You can’t perform that action at this time.