Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up spatial model names #2401

Merged
merged 1 commit into from Sep 26, 2019

Conversation

@cdeil
Copy link
Member

commented Sep 26, 2019

This PR cleans up the spatial model names (see #2353).

@adonath - Could you please update the ref YAML model file in gammapy-extra (see test_datasets_to_io fail) and merge this in?


PS: PyCharm is the best!

Screenshot 2019-09-26 at 11 59 12

Screenshot 2019-09-26 at 11 59 04

@cdeil cdeil added the cleanup label Sep 26, 2019
@cdeil cdeil added this to the 0.14 milestone Sep 26, 2019
@cdeil cdeil added this to In progress in Modeling via automation Sep 26, 2019
@adonath

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

I updated the model file in gammapy/gammapy-extra@0956bed. I'll go ahead and merge now...

@adonath adonath merged commit fc08c47 into gammapy:master Sep 26, 2019
3 of 9 checks passed
3 of 9 checks passed
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
gammapy.gammapy Build #20190926.7 had test failures
Details
gammapy.gammapy (Test Python36) Test Python36 failed
Details
gammapy.gammapy (Test Windows36) Test Windows36 failed
Details
gammapy.gammapy (Test Windows37) Test Windows37 failed
Details
Scrutinizer Analysis: 6 new issues, 30 updated code elements – Tests: passed
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
Modeling automation moved this from In progress to Done Sep 26, 2019
@adonath

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

Thanks @cdeil!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Modeling
  
Done
2 participants
You can’t perform that action at this time.