Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up spectral model names #2404

Merged
merged 18 commits into from Sep 26, 2019

Conversation

@cdeil
Copy link
Member

commented Sep 26, 2019

This PR cleans up the spectral model names (see #2353).

@adonath - could you please update the ref XML and YAML serialisation files (see test fails) and merge?

@cdeil cdeil added the cleanup label Sep 26, 2019
@cdeil cdeil added this to the 0.14 milestone Sep 26, 2019
@cdeil cdeil added this to In progress in Modeling via automation Sep 26, 2019
Copy link
Member

left a comment

Thanks @cdeil, I updated the model files here: gammapy/gammapy-extra@a0e44aa

@adonath adonath merged commit a4e7784 into gammapy:master Sep 26, 2019
4 of 9 checks passed
4 of 9 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
gammapy.gammapy Build #20190926.10 had test failures
Details
gammapy.gammapy (Test Python36) Test Python36 failed
Details
gammapy.gammapy (Test Windows36) Test Windows36 failed
Details
gammapy.gammapy (Test Windows37) Test Windows37 failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 13 new issues, 50 updated code elements – Tests: passed
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
Modeling automation moved this from In progress to Done Sep 26, 2019
@adonath

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

I'll go ahead and merge now and watch the CI build on master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Modeling
  
Done
2 participants
You can’t perform that action at this time.