Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove model XML serialization #2412

Merged
merged 1 commit into from Sep 27, 2019

Conversation

@QRemy
Copy link
Contributor

commented Sep 27, 2019

remove current xml serialization, it will be re-introduced latter
updating from_dict/to_dict on models to support ctools/scitools conventions

@cdeil cdeil self-assigned this Sep 27, 2019
@cdeil cdeil added the cleanup label Sep 27, 2019
@cdeil cdeil added this to the 0.14 milestone Sep 27, 2019
@cdeil cdeil added this to In progress in Modeling via automation Sep 27, 2019
@cdeil
cdeil approved these changes Sep 27, 2019
Copy link
Member

left a comment

@QRemy - Thanks!

I think removing and then rebuilding in a clean way is the best way forward.

We still have #1402 open as reminder.

@adonath - OK?

@cdeil cdeil requested a review from adonath Sep 27, 2019
@cdeil cdeil changed the title remove xml serialization Remove model XML serialization Sep 27, 2019
@adonath

This comment has been minimized.

Copy link
Member

commented Sep 27, 2019

Yes, +1 to remove. If there is anything useful to keep we can get it back from the git history anytime...

@cdeil cdeil merged commit 905d11d into gammapy:master Sep 27, 2019
8 of 9 checks passed
8 of 9 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
gammapy.gammapy Build #20190927.12 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
Modeling automation moved this from In progress to Done Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Modeling
  
Done
3 participants
You can’t perform that action at this time.