Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update astropy and numpy versions in Travis-CI #2433

Merged
merged 2 commits into from Oct 3, 2019

Conversation

@bsipocz
Copy link
Member

bsipocz commented Oct 3, 2019

Current version requirements state astropy>=3.2 and numpy>=1.16, so can't/shouldn't test older versions.

There are also mentions of numpy 1.9 in files in dev/docker, I would suggest to clean up/remove those as well rather than letting them code rot there.

@bsipocz bsipocz added this to the 0.15 milestone Oct 3, 2019
@cdeil
cdeil approved these changes Oct 3, 2019
Copy link
Member

cdeil left a comment

It would be better to change this build to explicitly test against the oldest versions we want to support as listed in setup.cfg, otherwise we'll accidentally start using features that e.g. are only available in Numpy 1.17, or in the future in Astropy 4.0, ...

But I'm also OK to just remove this build for now to get CI master green again, and to add the "oldest versions we support" build later.

@bsipocz

This comment has been minimized.

Copy link
Member Author

bsipocz commented Oct 3, 2019

Oh, for sure. I think you better test for a matrix of numpy and astropy versions than everything with the same one. But for astropy currently you only support the latest.

As for numpy, adding NUMPY_VERSION=1.16 for one of the jobs would do the trick, as I don't know a good way yet of how to pick up exactly the oldest versions from setup.py.
But maybe all of these will be easier to scatter around and manage in the azure matrix?

@cdeil cdeil merged commit 7f51d8e into gammapy:master Oct 3, 2019
9 of 10 checks passed
9 of 10 checks passed
gammapy.gammapy
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20191003.1 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
@adonath adonath changed the title Update versions in travis Update astropy and numpy versions in Travis-CI Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.