Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add modeling notebook with model plot examples #2435
This PR adds a
It's not written here - scope, content will have to be discussed a bit first and then someone has to actually write it. But I wanted to move the existing plot examples from the spatial and spectral models here, because I agree it's better to have one "model gallery" as @adonath mentioned a few days ago, and to keep the auto-generated API docs small and simple. Especially with models there is value in having different models in the same document and to be able to compare them.
@adonath - OK to go in this direction? And to limit the scope of this PR to just moving the existing examples like I did, i.e. not actually writing the notebook content now?
adonath left a comment
Thanks @cdeil! I've left one minor inline comment concerning the name of the notebook.
Some further comments:
Prefer to leave this to a later PR.
Am considering writing a PIG or wiki page to outline the docs and tutorial organisation we want for v1.0 and to have a good discussion in Oct, and then a clear plan to implement it in Nov.
Was already the case
I changed to
@adonath - OK to put like this for now?
(I can't reproduce this locally, and don't really understand it.)
For some reason, we pick up the
I can see how this might happen ... in SpectralModel.plot we use the pattern we use everywhere to get the axis via
So if the sky image plotting from above in the notebook creates some non-standard axis, we will keep re-using that?
@adonath - could you please also look at astropy/regions#296 and comment? Maybe we should clean up our MPL usage pattern in Gammapy also a bit, especially to avoid this accidental mixing of old wcs axis plots with later normal plots?