Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix and improve 2HWC catalog source models #2449
cdeil left a comment
@QRemy - Thanks!
The sky_models method is not covered by a test? - please add it.
Now that we have a sky_models method, I think we can improve the API and tests here:
@QRemy - Thoughts?
They describe the source model as a point source or a disk of fixed radius of 0.5, 1, 2 degrees by default, but they try to re-define this radius based on residual map:
I have added this comment in the sky_model docstring : The radius of the secondary source model is a rough estimate based on the residual excess above the point source model. This radius should not be regarded as a definite measurement of the source extent.
@QRemy and @cdeil For the hgps catalog we also have different spectral models and there we have chosen the pattern, that users can choose which model to return, see here: https://github.com/gammapy/gammapy/blob/master/gammapy/catalog/hess.py#L436
Maybe we just do the same here and add a
@cdeil I would prefer not to hide