Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve datasets serialisation #2455

Merged
merged 6 commits into from Oct 15, 2019

Conversation

@QRemy
Copy link
Contributor

QRemy commented Oct 14, 2019

-add dataset types registry
-simplify dict_to_datasets
-move update_dataset to MapDataset.update
then specific read/write/update methods should be added to the other dataset classes

@QRemy QRemy requested a review from adonath Oct 14, 2019
@QRemy QRemy added the cleanup label Oct 14, 2019
@adonath adonath self-assigned this Oct 14, 2019
@adonath adonath added this to the 0.15 milestone Oct 14, 2019
Copy link
Member

adonath left a comment

Thanks @QRemy! Please add a docstring to MapDataset.from_dict() and update the dataset yaml files in gammapy-extra to include the type keyword.

gammapy/cube/fit.py Show resolved Hide resolved
QRemy added 3 commits Oct 14, 2019
-add dataset types registry
-simplify dict_to_datasets
-move update_dataset to MapDataset.update
@QRemy QRemy force-pushed the QRemy:extend_datasets_serialization branch from 254c6ee to fb699a8 Oct 14, 2019
@QRemy QRemy force-pushed the QRemy:extend_datasets_serialization branch from 3bc6a09 to a5eebd2 Oct 14, 2019
Copy link
Member

adonath left a comment

Thanks @QRemy, of course we need tests for the serialisation of the other datasets (SpectrumDataset SpectrumDatasetOnOff...). But this can happen step by step in follow up PRs.

Copy link
Member

adonath left a comment

No further comments from my side.

@adonath adonath merged commit 757acb4 into gammapy:master Oct 15, 2019
6 of 9 checks passed
6 of 9 checks passed
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
Scrutinizer Running
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
gammapy.gammapy Build #20191015.2 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
@adonath adonath changed the title Improve datasets serialization to support different dataset classes Improve datasets serialisation Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.