Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FluxPointsDataset serialisation #2459

Merged
merged 11 commits into from Oct 16, 2019

Conversation

@QRemy
Copy link
Contributor

QRemy commented Oct 15, 2019

-add write and from_dict() methods to FluxPointsDataset
-add test case for use with Datasets.to_yaml() and .from_yaml()
assume model is a SkyModels instance

@QRemy QRemy requested a review from adonath Oct 15, 2019
@QRemy QRemy force-pushed the QRemy:add_FluxPointsDataset_serialization branch from 5f19443 to 833a19d Oct 15, 2019
@QRemy QRemy added the feature label Oct 15, 2019
@QRemy QRemy force-pushed the QRemy:add_FluxPointsDataset_serialization branch from 833a19d to ef35065 Oct 15, 2019
@cdeil cdeil added this to the 0.15 milestone Oct 15, 2019
Copy link
Member

adonath left a comment

I have added two follow up commits adding the docstrings (pair-coding with @QRemy ).

@adonath adonath merged commit 56d54ae into gammapy:master Oct 16, 2019
6 of 9 checks passed
6 of 9 checks passed
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
Scrutinizer Running
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
gammapy.gammapy Build #20191016.2 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
@adonath adonath changed the title Add FluxPointsDataset serialization Add FluxPointsDataset serialisation Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.