Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catalog and plotting utils #246

Merged
merged 1 commit into from Mar 30, 2015
Merged

Conversation

@adonath
Copy link
Member

@adonath adonath commented Mar 20, 2015

This updates the survey panel class and adds a few catalog utility functions.

@@ -295,3 +297,158 @@ def select_sky_box(table, lon_lim, lat_lim, frame):
mask = lon_mask & lat_mask

return table[mask]


def get_source_by_name(source, catalog, id_column='Source_Name'):

This comment has been minimized.

@cdeil

cdeil Mar 23, 2015
Member

Make this a public function, i.e. add to all?

This example reads Greens catalog from `gammapy.datasets` and writes it to a
ds9 region file.
>>> from gammapy.datasets import load_catalog_green

This comment has been minimized.

@cdeil

cdeil Mar 23, 2015
Member

Does this need to be indented?
I think we usually don't do this.

Can you check in the html docs how it looks and if it's necessary?

xborder : float
Free space to x border in inches
yborder : float
Free space to y border in inches
yspacing : float
Free space between slices in inches
xoverlap : float
Overlap between single panels.

This comment has been minimized.

@cdeil

cdeil Mar 23, 2015
Member

in deg?

@cdeil
Copy link
Member

@cdeil cdeil commented Mar 23, 2015

I've left three minor inline comments.
Please go ahead and merge once these are addressed.

@adonath adonath force-pushed the adonath:survey_panel_update branch from d4ad978 to 4c80b02 Mar 30, 2015
@coveralls
Copy link

@coveralls coveralls commented Mar 30, 2015

Coverage Status

Coverage decreased (-0.27%) to 45.78% when pulling 4c80b02 on adonath:survey_panel_update into 01c2707 on gammapy:master.

@adonath adonath force-pushed the adonath:survey_panel_update branch from 4c80b02 to 7465047 Mar 30, 2015
adonath added a commit that referenced this pull request Mar 30, 2015
Added catalog and plotting utils
@adonath adonath merged commit 4d935ae into gammapy:master Mar 30, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
adonath added a commit to adonath/gammapy that referenced this pull request Apr 1, 2015
@cdeil cdeil changed the title Added catalog and plotting utils Add catalog and plotting utils Apr 8, 2015
@cdeil cdeil added the feature label Apr 8, 2015
@cdeil cdeil added this to the 0.2 milestone Apr 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.