Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error raising, when model component moves out of the image #2461

Merged
merged 2 commits into from Oct 15, 2019

Conversation

@adonath
Copy link
Member

adonath commented Oct 15, 2019

This PR removes the error raising, when a model component drift out of the image. Instead the model contribution is just ignored in the likelihood evaluation, which seems the more reasonable choice.

@adonath adonath self-assigned this Oct 15, 2019
@adonath adonath added the cleanup label Oct 15, 2019
@adonath adonath added this to the 0.15 milestone Oct 15, 2019
@cdeil
cdeil approved these changes Oct 15, 2019
@adonath adonath merged commit 4e8e580 into gammapy:master Oct 15, 2019
8 of 9 checks passed
8 of 9 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 1 updated code elements – Tests: passed
Details
gammapy.gammapy Build #20191015.9 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.