Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Fermi-LAT 1FHL catalog #2476

Merged
merged 2 commits into from Oct 18, 2019
Merged

Remove Fermi-LAT 1FHL catalog #2476

merged 2 commits into from Oct 18, 2019

Conversation

@QRemy
Copy link
Contributor

QRemy commented Oct 18, 2019

remove 1FHL catalog

remove 1FHL catalog
@QRemy QRemy requested a review from cdeil Oct 18, 2019
@QRemy QRemy added the cleanup label Oct 18, 2019
@cdeil cdeil self-assigned this Oct 18, 2019
@cdeil cdeil added this to the 0.15 milestone Oct 18, 2019
@cdeil cdeil changed the title remove 1FHL catalog Remove 1FHL catalog Oct 18, 2019
@cdeil cdeil changed the title Remove 1FHL catalog Remove Fermi-LAT 1FHL catalog Oct 18, 2019
@cdeil

This comment has been minimized.

Copy link
Member

cdeil commented Oct 18, 2019

@QRemy - Thanks!

Please always x-ref relevant issues when opening a PR.
That's often useful when checking what was done for what reasons.
(e.g. someone might send feature request or PR next year, to add 1FHL).

In this case: #2423 (comment)

@cdeil

This comment has been minimized.

Copy link
Member

cdeil commented Oct 18, 2019

Another point: when doing cleanup, please always use some kind of full-text search (e.g. https://beyondgrep.com/ or PyCharm) and try to be complete.

In this case:

(gammapy-dev) hfm-1804a:gammapy deil$ ack 1FHL
docs/catalog/index.rst
21:* ``1fhl`` / `SourceCatalog1FHL` - First Fermi-LAT Catalog of Sources above 10 GeV

gammapy/catalog/tests/test_fermi.py
374:            "1FHL J0534.5+2201",
533:            "1FHL J0534.5+2201",

gammapy/catalog/fermi.py
884:    """Energy range of the Fermi 1FHL source catalog"""
1155:            "1FHL_Name",
1296:        source_name_alias = ("ASSOC", "3FGL_Name", "1FHL_Name", "TeVCat_Name")

examples/example_fermi_catalogs.py
5:    SourceCatalog1FHL,
31:        source=SourceCatalog1FHL()[name], label="Fermi 1FHL", color="c"

tutorials/source_population_model.ipynb
96:    "Several source population models, e.g. the 1FHL paper or Strong (2007), use power-law luminosity functions.\n",
98:    "Here we implement the \"reference model\" from the 1FHL catalog paper section 6.2."

CHANGES.rst
1098:    - Access to more Fermi-LAT catalogs (1FHL, 2FHL, 3FHL)
1179:- [#855] Add Fermi-LAT 1FHL catalogue (Julien Lefaucheur)
(gammapy-dev) hfm-1804a:gammapy deil$ ack 1fhl
docs/catalog/index.rst
21:* ``1fhl`` / `SourceCatalog1FHL` - First Fermi-LAT Catalog of Sources above 10 GeV
71:    ['gamma-cat', 'hgps', '2hwc', '3fgl', '4fgl', '1fhl', '2fhl', '3fhl', 'snrcat']

I'll remove those mentions now and merge, that's just a suggestion for future PRs.

@cdeil
cdeil approved these changes Oct 18, 2019
Copy link
Member

cdeil left a comment

@QRemy - Muchas gracias.

@cdeil cdeil merged commit e275485 into gammapy:master Oct 18, 2019
6 of 8 checks passed
6 of 8 checks passed
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
Scrutinizer Analysis: Running – Tests: pending
Details
gammapy.gammapy Build #20191018.10 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.