Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 2FHL catalog support #2478

Merged
merged 1 commit into from Oct 21, 2019
Merged

Improve 2FHL catalog support #2478

merged 1 commit into from Oct 21, 2019

Conversation

@QRemy
Copy link
Contributor

QRemy commented Oct 18, 2019

  • add more infos
  • add spatial_model and sky_model
  • have to check the extended template for RX J1713, for now I guess it's the same than for 3FGL and added a copy to read with 2FHL in gammapy-extra
- add more infos
- add spatial_model and sky_model
- have to check the extended template for RX J1713, for I guess it's the same than for 3FGL and added a copy to read with 2FHL in gammapy-extra
@QRemy QRemy requested a review from cdeil Oct 18, 2019
@QRemy QRemy added the feature label Oct 18, 2019
@cdeil cdeil self-assigned this Oct 18, 2019
@cdeil cdeil added this to the 0.15 milestone Oct 18, 2019
@cdeil

This comment has been minimized.

Copy link
Member

cdeil commented Oct 18, 2019

I see gammapy/gammapy-extra@fef1d9b

@adonath - could you please update the dataset index to fix this?
https://dev.azure.com/gammapy/gammapy/_build/results?buildId=2137

Otherwise 👍 to merge this in.

(the string formatting stuff can be shortened, but that's the case for all catalogs, I can do that in a follow-up PR)

@cdeil cdeil assigned adonath and unassigned cdeil Oct 21, 2019
@adonath

This comment has been minimized.

Copy link
Member

adonath commented Oct 21, 2019

I updated the dataset index file in 2b2b475

@cdeil
cdeil approved these changes Oct 21, 2019
@cdeil cdeil merged commit af1b79d into gammapy:master Oct 21, 2019
4 of 9 checks passed
4 of 9 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
gammapy.gammapy Build #20191018.18 had test failures
Details
gammapy.gammapy (Test Python36) Test Python36 failed
Details
gammapy.gammapy (Test Windows36) Test Windows36 failed
Details
gammapy.gammapy (Test Windows37) Test Windows37 failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 2 new issues, 9 updated code elements – Tests: passed
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.