Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default offset value in simulate_dataset() #2486

Merged
merged 3 commits into from Oct 28, 2019

Conversation

@facero
Copy link
Contributor

facero commented Oct 24, 2019

to avoid irfs issue at offset 0° mentioned in #2484

to avoid irfs issue at offset 0°
@cdeil cdeil requested a review from adonath Oct 24, 2019
@cdeil cdeil added the cleanup label Oct 24, 2019
@cdeil cdeil added this to the 0.15 milestone Oct 24, 2019
@cdeil cdeil added this to To do in gammapy.maps via automation Oct 24, 2019
gammapy.maps automation moved this from To do to In progress Oct 24, 2019
Copy link
Member

adonath left a comment

Thanks @facero, I'm sure this will change require adapting a few tests as well. Do you have time to run the tests locally and make the corresponding changes?

all passed
@cdeil cdeil assigned facero and unassigned adonath Oct 25, 2019
should pass now
@adonath adonath merged commit 1b8a95c into gammapy:master Oct 28, 2019
9 checks passed
9 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20191025.7 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
gammapy.maps automation moved this from In progress to Done Oct 28, 2019
@adonath

This comment has been minimized.

Copy link
Member

adonath commented Oct 28, 2019

Thanks @facero!

@facero facero deleted the facero:simulate_dataset branch Oct 28, 2019
@adonath adonath changed the title update default value in simulate_dataset (0°->1°) Update default value in simulate_dataset (0°->1°) Nov 18, 2019
@adonath adonath changed the title Update default value in simulate_dataset (0°->1°) Update default offset value in simulate_dataset (0°->1°) Nov 18, 2019
@adonath adonath changed the title Update default offset value in simulate_dataset (0°->1°) Update default offset value in simulate_dataset() Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
gammapy.maps
  
Done
3 participants
You can’t perform that action at this time.