New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data store and observation table classes, improve event list classes #249

Merged
merged 2 commits into from Apr 13, 2015

Conversation

Projects
None yet
2 participants
@cdeil
Member

cdeil commented Mar 31, 2015

This PR contains the following changes:

  • Add DataStore and DataStoreIndex classes
  • Add ObservationTable class, which represents a run list
  • Add event list stacking and utility functions
return os.path.join(group_folder, obs_folder, filename)
class DataStoreIndexTable(Table):

This comment has been minimized.

@cdeil

cdeil Mar 31, 2015

Member

@taldcroft - This is the Astropy Table subclass I mentioned here where I want to do some cleanup on read.

I'm still not sure what the best approach is:

  1. Overwrite __init__ and call _init_cleanup from there?
  2. Overwrite read and call _init_cleanup from there? (this is what I do at the moment and it seems to work OK, but it does make an extra copy just so that I can change the type to be DataStoreIndexTable and not Table)
  3. Add a read_and_cleanup method, i.e. the user has to specify that they want to read a FITS table that needs cleanup.

The use case here is that I have the same table info in somewhat different formats, and I want to normalize it to the format I like on read.

@cdeil

cdeil Mar 31, 2015

Member

@taldcroft - This is the Astropy Table subclass I mentioned here where I want to do some cleanup on read.

I'm still not sure what the best approach is:

  1. Overwrite __init__ and call _init_cleanup from there?
  2. Overwrite read and call _init_cleanup from there? (this is what I do at the moment and it seems to work OK, but it does make an extra copy just so that I can change the type to be DataStoreIndexTable and not Table)
  3. Add a read_and_cleanup method, i.e. the user has to specify that they want to read a FITS table that needs cleanup.

The use case here is that I have the same table info in somewhat different formats, and I want to normalize it to the format I like on read.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 1, 2015

Coverage Status

Coverage decreased (-0.21%) to 45.59% when pulling 16f072b on cdeil:datastore into 4d935ae on gammapy:master.

coveralls commented Apr 1, 2015

Coverage Status

Coverage decreased (-0.21%) to 45.59% when pulling 16f072b on cdeil:datastore into 4d935ae on gammapy:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 3, 2015

Coverage Status

Coverage decreased (-0.27%) to 45.52% when pulling 1a69fe2 on cdeil:datastore into 0f6ffbd on gammapy:master.

coveralls commented Apr 3, 2015

Coverage Status

Coverage decreased (-0.27%) to 45.52% when pulling 1a69fe2 on cdeil:datastore into 0f6ffbd on gammapy:master.

@cdeil cdeil changed the title from Add DataStore class to Add data store and observation table classes, improve event list classes Apr 8, 2015

@cdeil cdeil added the feature label Apr 8, 2015

@cdeil cdeil added this to the 0.2 milestone Apr 8, 2015

@cdeil cdeil self-assigned this Apr 8, 2015

@cdeil cdeil referenced this pull request Apr 11, 2015

Closed

Implement EventList class #185

@cdeil

This comment has been minimized.

Show comment
Hide comment
@cdeil

cdeil Apr 13, 2015

Member

This is unfinished, but I'm out of time, merging this now and will continue working on these classes (and add tests / docs) in new PR in the future.

Member

cdeil commented Apr 13, 2015

This is unfinished, but I'm out of time, merging this now and will continue working on these classes (and add tests / docs) in new PR in the future.

cdeil added a commit that referenced this pull request Apr 13, 2015

Merge pull request #249 from cdeil/datastore
Add data store and observation table classes, improve event list classes

@cdeil cdeil merged commit d89ced4 into gammapy:master Apr 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment