Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MapDataset.mask_fit and MapDataset.mask_safe to maps #2492

Merged
merged 3 commits into from Oct 28, 2019

Conversation

@AtreyeeS
Copy link
Member

AtreyeeS commented Oct 28, 2019

This PR makes MapDataset.mask_fit and MapDataset.mask_safe a Map object

@AtreyeeS AtreyeeS requested a review from adonath Oct 28, 2019
@adonath adonath self-assigned this Oct 28, 2019
@adonath adonath added the cleanup label Oct 28, 2019
@adonath adonath added this to the 0.15 milestone Oct 28, 2019
Copy link
Member

adonath left a comment

Thanks a lot @AtreyeeS! Looks good to me, I have no further comments...

@adonath adonath merged commit ed38c24 into gammapy:master Oct 28, 2019
9 checks passed
9 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 1 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20191028.2 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
@adonath adonath changed the title Change `MapDataset.mask_fit` and `MapDataset.mask_safe` to maps Change MapDataset.mask_fit and MapDataset.mask_safe to maps Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.