Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PSFMap.sample_coord method #2496

Merged
merged 1 commit into from Oct 31, 2019
Merged

Conversation

@fabiopintore
Copy link
Contributor

fabiopintore commented Oct 30, 2019

This PR continues the previously opened PR #2487 .

@cdeil cdeil added the feature label Oct 30, 2019
@cdeil cdeil added this to the 0.15 milestone Oct 30, 2019
@cdeil cdeil added this to In progress in gammapy.cube via automation Oct 30, 2019
Copy link
Member

adonath left a comment

Thanks a lot @fabiopintore! This PR looks good to me now. Review was done in #2487. Let's wait for Travis and merge...

@cdeil cdeil merged commit c0f88a5 into gammapy:master Oct 31, 2019
8 of 9 checks passed
8 of 9 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 3 updated code elements – Tests: passed
Details
gammapy.gammapy Build #20191030.1 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
gammapy.cube automation moved this from In progress to Done Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
gammapy.cube
  
Done
3 participants
You can’t perform that action at this time.