Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PhaseBackgroundEstimator to PhaseBackgroundMaker #2497

Merged
merged 4 commits into from Oct 30, 2019

Conversation

@adonath
Copy link
Member

adonath commented Oct 30, 2019

This PR refactors the PhaseBackgroundEstimator to the new data reduction scheme, adds a few more tests and adapts the pulsar_analysis.ipynb notebook.

@adonath adonath self-assigned this Oct 30, 2019
@adonath adonath added this to the 0.15 milestone Oct 30, 2019
@adonath adonath added the cleanup label Oct 30, 2019
@adonath adonath force-pushed the adonath:refactor_phase_background_estimator branch from 0111f69 to d3a4229 Oct 30, 2019
@adonath adonath merged commit 97d2e63 into gammapy:master Oct 30, 2019
8 checks passed
8 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20191030.3 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.