Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .to_sherpa() methods #2521

Merged
merged 2 commits into from Nov 7, 2019
Merged

Conversation

@adonath
Copy link
Member

adonath commented Nov 7, 2019

This PR remove the EnergyDispersion.to_sherpa() and EffectiveAreaTable.to_sherpa() methods. The were untested and not documented. Our current tutorials show the approach to write the data to disk in a sherpa compatible format and also show how to read it back using sherpa. I think that's the much clearer and consistent interface for now. So I decided to remove it.

@adonath adonath self-assigned this Nov 7, 2019
@adonath adonath added the cleanup label Nov 7, 2019
@adonath adonath added this to the 0.15 milestone Nov 7, 2019
@adonath adonath merged commit 4118838 into gammapy:master Nov 7, 2019
0 of 8 checks passed
0 of 8 checks passed
gammapy.gammapy (DevDocs) DevDocs failed
Details
gammapy.gammapy (Lint) Lint failed
Details
gammapy.gammapy (Test Python36) Test Python36 failed
Details
gammapy.gammapy (Test Windows36) Test Windows36 failed
Details
gammapy.gammapy (Test Windows37) Test Windows37 failed
Details
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
Scrutinizer Running
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@cdeil

This comment has been minimized.

Copy link
Member

cdeil commented Nov 7, 2019

@cdeil cdeil added this to To do in gammapy.irf via automation Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
gammapy.irf
  
To do
2 participants
You can’t perform that action at this time.