Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WcsGeom.cutout_info information to WCS header #2536

Merged
merged 5 commits into from Nov 13, 2019

Conversation

@adonath
Copy link
Member

adonath commented Nov 13, 2019

This PR adds the (optional) cutout_info of a WcsGeom to the WCS header. This allow to cutout maps, write them to file, read them back and stack into a larger map with an aligned WCS geometry. This also allows to get rid of the reference to the parent geometry.

@adonath adonath self-assigned this Nov 13, 2019
@adonath adonath added this to the 0.15 milestone Nov 13, 2019
@adonath adonath added this to To do in gammapy.maps via automation Nov 13, 2019
@cdeil cdeil added the feature label Nov 13, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #2536 into master will increase coverage by <.01%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2536      +/-   ##
==========================================
+ Coverage   91.48%   91.48%   +<.01%     
==========================================
  Files         145      145              
  Lines       16550    16564      +14     
==========================================
+ Hits        15141    15154      +13     
- Misses       1409     1410       +1
Impacted Files Coverage Δ
gammapy/maps/wcsnd.py 95.37% <100%> (ø) ⬆️
gammapy/maps/utils.py 87.01% <100%> (+0.9%) ⬆️
gammapy/maps/wcs.py 96.9% <95%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e297805...aac02ab. Read the comment docs.

@adonath adonath merged commit daf10e8 into gammapy:master Nov 13, 2019
11 checks passed
11 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 4 updated code elements – Tests: passed
Details
codecov/patch 96.15% of diff hit (target 91.48%)
Details
codecov/project 91.48% (+<.01%) compared to e297805
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20191113.20 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
gammapy.maps automation moved this from To do to Done Nov 13, 2019
@adonath adonath changed the title Add `.cutout_info` information to WCS header Add WcsGeom.cutout_info information to WCS header Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
gammapy.maps
  
Done
2 participants
You can’t perform that action at this time.