Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SafeMaskMaker and adapt mask_safe handling in MapDatasetMaker #2538

Merged
merged 17 commits into from Nov 14, 2019

Conversation

@adonath
Copy link
Member

adonath commented Nov 13, 2019

This PR implements a few changes related to the SafeMaskMaker and mask safe handling in general:

  • Move SafeMaskMaker to gammapy/cube
  • Remove offset mask application from MapDatasetMaker
  • Implement offset-max mask option in SafeMaskMaker
  • Adapt tests and tutorials
@adonath adonath self-assigned this Nov 13, 2019
@adonath adonath added this to the 0.15 milestone Nov 13, 2019
@adonath adonath added the cleanup label Nov 13, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #2538 into master will increase coverage by 0.04%.
The diff coverage is 97.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2538      +/-   ##
==========================================
+ Coverage   91.41%   91.45%   +0.04%     
==========================================
  Files         144      144              
  Lines       16297    16297              
==========================================
+ Hits        14898    14905       +7     
+ Misses       1399     1392       -7
Impacted Files Coverage Δ
gammapy/cube/psf_map.py 95.57% <100%> (+0.12%) ⬆️
gammapy/cube/background.py 79.41% <100%> (ø) ⬆️
gammapy/maps/wcsnd.py 95.4% <100%> (+0.02%) ⬆️
gammapy/cube/fit.py 89.55% <100%> (-0.16%) ⬇️
gammapy/spectrum/make.py 97.05% <100%> (+2.16%) ⬆️
gammapy/analysis/core.py 94.21% <100%> (+0.05%) ⬆️
gammapy/cube/edisp_map.py 95.65% <100%> (+0.11%) ⬆️
gammapy/cube/make.py 96.81% <96%> (-0.85%) ⬇️
gammapy/catalog/fermi.py 94.63% <0%> (-0.01%) ⬇️
gammapy/maps/wcs.py 96.9% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c71d5d7...8d4e739. Read the comment docs.

@adonath adonath merged commit 11a4d9c into gammapy:master Nov 14, 2019
12 checks passed
12 checks passed
greeting
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 10 updated code elements – Tests: passed
Details
codecov/patch 97.93% of diff hit (target 91.41%)
Details
codecov/project 91.45% (+0.04%) compared to d484ae9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20191114.1 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
@adonath adonath changed the title Move `SafeMaskMaker` and adapt mask_safe handling in `MapDatasetMaker` Move SafeMaskMaker and adapt mask_safe handling in MapDatasetMaker Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.