New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move SafeMaskMaker and adapt mask_safe handling in MapDatasetMaker #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2538 +/- ##
==========================================
+ Coverage 91.41% 91.45% +0.04%
==========================================
Files 144 144
Lines 16297 16297
==========================================
+ Hits 14898 14905 +7
+ Misses 1399 1392 -7
Continue to review full report at Codecov.
|
adonath
changed the title
Move
Move SafeMaskMaker and adapt mask_safe handling in MapDatasetMaker
Nov 18, 2019
SafeMaskMaker
and adapt mask_safe handling in MapDatasetMaker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a few changes related to the
SafeMaskMaker
and mask safe handling in general:SafeMaskMaker
togammapy/cube
MapDatasetMaker
SafeMaskMaker