Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Rename likelihood to stat #2546
This pull request fixes #2149, it renames "likelihood", "loglike" terms to "stat".
I noticed that the flux point and light curve code is a lot of duplicated copy & paste, I had to do the same edits twice (possibly introducing bugs along the way). Can we do better?
Tests pass, but @adonath - there's probably places I missed?
(I didn't do the
@@ Coverage Diff @@ ## master #2546 +/- ## ========================================= Coverage ? 91.45% ========================================= Files ? 144 Lines ? 16296 Branches ? 0 ========================================= Hits ? 14904 Misses ? 1392 Partials ? 0
The remaining task here is to deal with the SED profiles.
From the description here, it sounds to me like
I think there was a bug then, because here we put
So the factor 2 is incorrect, and for the sign I'm not sure.
@adonath - ?
@adonath - Ready for final review. Locally
I didn't touch
I checked the plot in