Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more options to Minuit wrapper #2557

Merged
merged 3 commits into from Nov 18, 2019
Merged

Conversation

@QRemy
Copy link
Contributor

QRemy commented Nov 18, 2019

@QRemy QRemy added the feature label Nov 18, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #2557 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2557      +/-   ##
==========================================
+ Coverage   91.31%   91.31%   +<.01%     
==========================================
  Files         144      144              
  Lines       16205    16210       +5     
==========================================
+ Hits        14797    14802       +5     
  Misses       1408     1408
Impacted Files Coverage Δ
gammapy/modeling/iminuit.py 91.01% <100%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3975d25...ee4133e. Read the comment docs.

@QRemy QRemy requested a review from cdeil Nov 18, 2019
@cdeil cdeil self-assigned this Nov 18, 2019
@cdeil cdeil added this to the 0.15 milestone Nov 18, 2019
@cdeil cdeil added this to In progress in gammapy.modeling via automation Nov 18, 2019
@cdeil
cdeil approved these changes Nov 18, 2019
Copy link
Member

cdeil left a comment

Merçi!

@cdeil cdeil merged commit df0572e into gammapy:master Nov 18, 2019
12 checks passed
12 checks passed
greeting
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 1 updated code elements – Tests: passed
Details
codecov/patch 100% of diff hit (target 91.31%)
Details
codecov/project 91.31% (+<.01%) compared to 3975d25
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20191118.9 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
gammapy.modeling automation moved this from In progress to Done Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.