Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gammapy.utils.nddata.sqrt_space #2558

Merged
merged 1 commit into from Nov 18, 2019
Merged

Remove gammapy.utils.nddata.sqrt_space #2558

merged 1 commit into from Nov 18, 2019

Conversation

@cdeil
Copy link
Member

cdeil commented Nov 18, 2019

This PR removes gammapy.utils.nddata.sqrt_space, using MapAxis instead.
One step to fix #2271 .

@cdeil cdeil added the cleanup label Nov 18, 2019
@cdeil cdeil added this to the 0.15 milestone Nov 18, 2019
@cdeil cdeil requested a review from adonath Nov 18, 2019
@cdeil cdeil self-assigned this Nov 18, 2019
@cdeil cdeil added this to In progress in gammapy.utils via automation Nov 18, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #2558 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2558      +/-   ##
==========================================
+ Coverage   91.31%   91.31%   +<.01%     
==========================================
  Files         144      144              
  Lines       16205    16203       -2     
==========================================
- Hits        14797    14796       -1     
+ Misses       1408     1407       -1
Impacted Files Coverage Δ
gammapy/utils/nddata.py 90.76% <100%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3975d25...6dd8111. Read the comment docs.

Copy link
Member

adonath left a comment

Thanks @cdeil! I have no further comments...

@cdeil cdeil merged commit d443267 into gammapy:master Nov 18, 2019
12 checks passed
12 checks passed
greeting
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/patch 100% of diff hit (target 91.31%)
Details
codecov/project 91.31% (+<.01%) compared to 3975d25
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20191118.10 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
gammapy.utils automation moved this from In progress to Done Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
gammapy.utils
  
Done
2 participants
You can’t perform that action at this time.