Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace energy grid helper functions with MapAxis #2559

Merged
merged 2 commits into from Nov 19, 2019
Merged

Conversation

@cdeil
Copy link
Member

cdeil commented Nov 19, 2019

This PR implements a step towards resolving #2271, to have less code to make log energy grids.

  • Replace gammapy.utils.energy.energy_logcenter with MapAxis
  • Replace gammapy.utils.energy.energy_logspace with MapAxis
@cdeil cdeil added the cleanup label Nov 19, 2019
@cdeil cdeil added this to the 0.15 milestone Nov 19, 2019
@cdeil cdeil self-assigned this Nov 19, 2019
@cdeil cdeil added this to In progress in gammapy.utils via automation Nov 19, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #2559 into master will increase coverage by 0.15%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2559      +/-   ##
==========================================
+ Coverage   91.31%   91.47%   +0.15%     
==========================================
  Files         144      142       -2     
  Lines       16208    16123      -85     
==========================================
- Hits        14801    14749      -52     
+ Misses       1407     1374      -33
Impacted Files Coverage Δ
gammapy/irf/psf_table.py 84.13% <100%> (ø) ⬆️
gammapy/irf/energy_dispersion.py 98.14% <100%> (-0.01%) ⬇️
gammapy/data/event_list.py 90.11% <100%> (-0.04%) ⬇️
gammapy/irf/psf_3d.py 98.17% <100%> (ø) ⬆️
gammapy/modeling/models/spectral.py 97.57% <100%> (ø) ⬆️
gammapy/irf/effective_area.py 93.57% <100%> (-0.03%) ⬇️
gammapy/maps/geom.py 90.59% <100%> (ø) ⬆️
gammapy/irf/psf_gauss.py 77.55% <50%> (ø) ⬆️
gammapy/maps/wcs.py 96.51% <0%> (-0.47%) ⬇️
gammapy/maps/base.py 81.5% <0%> (-0.38%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df0572e...e5e743d. Read the comment docs.

Copy link
Member

adonath left a comment

Thanks @cdeil! If have no further comments...

@cdeil cdeil merged commit 8909741 into gammapy:master Nov 19, 2019
12 checks passed
12 checks passed
greeting
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 1 updated code elements – Tests: passed
Details
codecov/patch 96.15% of diff hit (target 91.31%)
Details
codecov/project 91.47% (+0.15%) compared to df0572e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20191119.15 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
gammapy.utils automation moved this from In progress to Done Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
gammapy.utils
  
Done
2 participants
You can’t perform that action at this time.