Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove map reprojection functionality #2562

Merged
merged 6 commits into from Nov 19, 2019
Merged

Conversation

@adonath
Copy link
Member

adonath commented Nov 19, 2019

Description

This pull request removes the Map.reproject() method. Following #2549 and some discussion at the coding sprint we agreed to just remove the reproduction functionality. For our use-cases a simple call to .interp_by_coord() is sufficient. Currently we don't need any flux-preserving
methods.

Dear reviewer
Please review and merge.

@adonath adonath self-assigned this Nov 19, 2019
@adonath adonath added this to the 0.15 milestone Nov 19, 2019
@adonath adonath added the cleanup label Nov 19, 2019
@adonath adonath added this to To do in gammapy.maps via automation Nov 19, 2019
@adonath adonath requested a review from cdeil Nov 19, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #2562 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2562      +/-   ##
==========================================
+ Coverage   91.33%   91.48%   +0.15%     
==========================================
  Files         144      143       -1     
  Lines       16221    16133      -88     
==========================================
- Hits        14815    14759      -56     
+ Misses       1406     1374      -32
Impacted Files Coverage Δ
gammapy/maps/base.py 81.5% <ø> (-0.38%) ⬇️
gammapy/maps/hpxnd.py 95.85% <ø> (-0.13%) ⬇️
gammapy/maps/wcsnd.py 95.97% <100%> (+0.86%) ⬆️
gammapy/maps/wcs.py 96.51% <0%> (-0.47%) ⬇️
gammapy/maps/geom.py 90.4% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1957c8d...5062d3d. Read the comment docs.

@cdeil
cdeil approved these changes Nov 19, 2019
Copy link
Member

cdeil left a comment

Mui bien!

@adonath adonath merged commit ec170b0 into gammapy:master Nov 19, 2019
12 checks passed
12 checks passed
greeting
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/patch 100% of diff hit (target 91.33%)
Details
codecov/project 91.48% (+0.15%) compared to 1957c8d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
gammapy.gammapy Build #20191119.9 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
gammapy.maps automation moved this from To do to Done Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
gammapy.maps
  
Done
2 participants
You can’t perform that action at this time.