Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in memory Observation class #2563

Merged
merged 7 commits into from Nov 19, 2019
Merged

Add in memory Observation class #2563

merged 7 commits into from Nov 19, 2019

Conversation

@AtreyeeS
Copy link
Member

AtreyeeS commented Nov 19, 2019

Description

This adds an in-memory Observation class for making binned simulations

Add gammapy.data.Observation

Similar to #1972

@cdeil cdeil added the feature label Nov 19, 2019
@cdeil cdeil added this to the 0.15 milestone Nov 19, 2019
@cdeil cdeil added this to To do in gammapy.data via automation Nov 19, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #2563 into master will decrease coverage by 0.06%.
The diff coverage is 73.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2563      +/-   ##
==========================================
- Coverage   91.48%   91.41%   -0.07%     
==========================================
  Files         143      142       -1     
  Lines       16133    16162      +29     
==========================================
+ Hits        14759    14775      +16     
- Misses       1374     1387      +13
Impacted Files Coverage Δ
gammapy/cube/make.py 95.65% <100%> (-0.73%) ⬇️
gammapy/data/observations.py 77.73% <72.5%> (-1.67%) ⬇️
gammapy/data/event_list.py 90.11% <0%> (-0.04%) ⬇️
gammapy/irf/effective_area.py 93.57% <0%> (-0.03%) ⬇️
gammapy/irf/energy_dispersion.py 98.14% <0%> (-0.01%) ⬇️
gammapy/utils/energy.py
gammapy/maps/geom.py 90.59% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec170b0...fd86164. Read the comment docs.

Copy link
Member

adonath left a comment

Thanks @AtreyeeS. I have no further comments..

@adonath adonath merged commit eb9bc11 into gammapy:master Nov 19, 2019
8 of 10 checks passed
8 of 10 checks passed
greeting
Details
Scrutinizer Running
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
gammapy.gammapy Build #20191119.21 succeeded
Details
gammapy.gammapy (DevDocs) DevDocs succeeded
Details
gammapy.gammapy (Lint) Lint succeeded
Details
gammapy.gammapy (Test Python36) Test Python36 succeeded
Details
gammapy.gammapy (Test Windows36) Test Windows36 succeeded
Details
gammapy.gammapy (Test Windows37) Test Windows37 succeeded
Details
gammapy.data automation moved this from To do to Done Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
gammapy.data
  
Done
3 participants
You can’t perform that action at this time.